[Mulgara-dev] committing guidelines

[Life is hard, and then you die]

May I suggest something regarding how many changes to commit together?
I was just looking through r718 (sorry Paul, nothing personal, just a
very obvious example that pushed my button) trying to figure out what
exactly the change was, and it was a right royal pain because about
90% of the changes were whitespace/comments/general-formatting fixes
and only about 10% were related to the actual thing being fixed.

I understand very well that when you're in a file fixing stuff that
you want to also fix all the formatting things, but I would like to
suggest that those two things please be pulled apart and committed
separately. Yes, it's a pain to go in an undo various stuff and commit
in multiple parts, but if we want others to be able to review the
changes then this is essential. IMNSHO, if things like formatting
fixes make up more than 10% of the changes then they should be
committed separately. I even go so far as to say that, e.g., if you
have two not directly related sets of changes a files and one set also
affects another file, then again split them up into two separate
commits.

Anyway, that's my suggestion. Flames away...


  Cheers,

  Ronald