[Mulgara-dev] Size of server1 directory

[Life is hard, and then you die]

On Tue, Jul 31, 2007 at 11:13:54AM -0400, David Moll wrote:
> I just realized that I only sent this message to Ronald yesterday.
> 
> We are currently running Rev 279 on our production system.  I think that
> Rev 282 or Rev 296 may have fixed the problem, but I'm not sure.  I
> looked through the code changes for 282 and 296 and while there were
> some significant changes to some of the core modules I didn't see
> anything related to closing Answers.  But I'm only familiar with a few
> of the classes, none of which had significant changes.

rev 169 on ItqlInterpreterBean fixed a missing close. There were also
some other fixes later on.

> We're testing version 1.1.0 on one of our servers now.

Oh, warning to everybody: I just discovered a serious problem with the
transactions a couple days ago - if you run two transactions in
parallel (separate sessions), the second one will steal the write
lock, messing things up. I'm still working on getting some tests
working and hence why I haven't checked in the fix yet, but in the
mean time the fix is simple:

------------------------------------------------------------------
Index: jar/resolver/java/org/mulgara/resolver/MulgaraTransactionManager.java
===================================================================
--- jar/resolver/java/org/mulgara/resolver/MulgaraTransactionManager.java      (revision 325)
+++ jar/resolver/java/org/mulgara/resolver/MulgaraTransactionManager.java      (working copy)
@@ -167,7 +167,7 @@
    */
   private MulgaraTransaction obtainWriteLock(DatabaseSession session)
       throws MulgaraTransactionException {
-    while (currentWritingSession != null && !writeLockReserved()) {
+    while (currentWritingSession != null || !writeLockReserved()) {
       try {
         writeLockCondition.await();
       } catch (InterruptedException ei) {
------------------------------------------------------------------


  Cheers,

  Ronald


> -----Original Message-----
> From: mulgara-dev-bounces at mulgara.org
> [mailto:mulgara-dev-bounces at mulgara.org] On Behalf Of Life is hard, and
> then you die
> Sent: Monday, July 30, 2007 2:48 PM
> To: mulgara-dev at mulgara.org
> Subject: Re: [Mulgara-dev] Size of server1 directory
> 
> On Mon, Jul 30, 2007 at 02:23:01PM -0400, David Moll wrote:
> > 
> > >>Yes, the problem is due to unclosed Answer objects.
> > >>You say that you're using SOAP?  So that means all your results are
> > coming back to you as XML?  
> > 
> > Yes, and yes.
> > 
> > >>I thought we had closed everything after
> > >>serialization.  I must be wrong.  :-(
> > 
> > I thought so too - I remember seeing a finally block that closed all
> > answers.
> 
> What version of mulgara are you running? There've been a bunch of
> fixes in this area since 1.0.0.
> 
> 
>   Cheers,
> 
>   Ronald
>