[Mulgara-svn] r1378 - in trunk/src/jar: util/java/org/mulgara/util util-xa/java/org/mulgara/store/xa

alexhall at mulgara.org alexhall at mulgara.org
Wed Nov 12 18:39:27 UTC 2008


Author: alexhall
Date: 2008-11-12 10:39:26 -0800 (Wed, 12 Nov 2008)
New Revision: 1378

Modified:
   trunk/src/jar/util-xa/java/org/mulgara/store/xa/MappedBlockFile.java
   trunk/src/jar/util/java/org/mulgara/util/MappedIntFile.java
Log:
Address a Windows performance issue.  Eliminate call to super.force() in the mapped block and int files.  For mapped files, this call is unnecessary because the only operation on a file channel to force is a possible truncation, so no data can be lost on abnormal termination.  The force method on the FileChannel class is causes significant performance problems on Windows.

Modified: trunk/src/jar/util/java/org/mulgara/util/MappedIntFile.java
===================================================================
--- trunk/src/jar/util/java/org/mulgara/util/MappedIntFile.java	2008-11-11 15:33:50 UTC (rev 1377)
+++ trunk/src/jar/util/java/org/mulgara/util/MappedIntFile.java	2008-11-12 18:39:26 UTC (rev 1378)
@@ -290,8 +290,6 @@
     for (int i = 0; i < nrMappedRegions; ++i) {
       mappedByteBuffers[i].force();
     }
-
-    super.force();
   }
 
   /**

Modified: trunk/src/jar/util-xa/java/org/mulgara/store/xa/MappedBlockFile.java
===================================================================
--- trunk/src/jar/util-xa/java/org/mulgara/store/xa/MappedBlockFile.java	2008-11-11 15:33:50 UTC (rev 1377)
+++ trunk/src/jar/util-xa/java/org/mulgara/store/xa/MappedBlockFile.java	2008-11-12 18:39:26 UTC (rev 1378)
@@ -222,10 +222,6 @@
     for (int i = 0; i < nrMappedRegions; ++i) {
       mappedByteBuffers[i].force();
     }
-
-    super.force();
-
-    // force file metadata
   }
 
   /**




More information about the Mulgara-svn mailing list