[Mulgara-general] Re: [Mulgara-dev] A 1.0.1 release, and looking forward from there.

[Life is hard, and then you die]

On Fri, Aug 24, 2007 at 06:13:28PM +1000, Andrae Muys wrote:
> 
> I have just finished reviewing Ronald's fix to the transaction  
> manager.  He was right, the test should have been OR not AND.  I have  
> extracted the relevant test into a function to make it clearer what  
> is supposed to be going on.
> 
> Regarding the removal of the cascade from implicitRollback, I agree  
> that it is unnecessary - but only if the couple of cleanup lines are  
> migrated into the abort cascade.

Thanks for the review! I wasn't 100% sure on all the paths and states
into that implicitRollback cleanup, but it did fix the NPE ;-)


  Cheers,

  Ronald