[Mulgara-dev] Mulgara SAIL and SPARQL tests

[James Leigh]

On Wed, 2008-05-07 at 19:29 -0500, Paul Gearon wrote:
> Hi James,
> 
> On Wed, May 7, 2008 at 3:54 PM, James Leigh <james-nospam at leighnet.ca> wrote:
> >  Once you provide a fix for the triple-pattern-003 the Mulgara-SAIL will
> >  pass nearly all our SPARQL tests[*].
> 
> Fixed. It ended up being a REALLY tough one to fix, but it seems to
> work perfectly now. It certainly passes the triple-pattern-003 test.
> 
> I'll try to extract patches for you in the morning (it's Anne and my
> anniversary tonight, so I get the night off).
> 

Paul, can you explain why you are using an array of fixed size 2 in the
code below? I am getting an array out of bounds exception when there are
three variables in the select clause.

James
---

+      // Set the variables. Using an ordered set.
+      Set uniqueVariables = new LinkedHashSet();
+      columnMap = new int[2];
       for (int index = 0; index < baseTuples.getVariables().length; index++) {
         Object obj = constraint.getElement(index);
         if (obj instanceof Variable) {
@@ -203,6 +236,7 @@
         Object obj = constraint.getElement(index);
         if (obj instanceof Variable) {
           if (!((Variable) obj).equals(Variable.FROM)) {
+            if (!uniqueVariables.contains(obj)) columnMap[uniqueVariables.size()] = columnOrder[index];
             uniqueVariables.add(obj);
           }
         }
@@ -207,14 +241,7 @@
           }
         }
       }