[Mulgara-dev] Re: [Mulgara-svn] r359 - branches/nw-interface/src/jar/itql/sablecc

[Life is hard, and then you die]

On Tue, Aug 21, 2007 at 12:37:59AM -0500, pag at mulgara.org wrote:
> Author: pag
> Date: 2007-08-21 00:37:58 -0500 (Tue, 21 Aug 2007)
> New Revision: 359
> 
> Modified:
>    branches/nw-interface/src/jar/itql/sablecc/itql.grammar
> Log:
> Attempted to add language tag support
> 
> Modified: branches/nw-interface/src/jar/itql/sablecc/itql.grammar
> ===================================================================
[snip]
>    literal =
> -    [opening]:quote strand* [closing]:quote datatype?;
> +    [opening]:quote strand* [closing]:quote language? datatype?;

Shouldn't this really be an or between datatype and language? I.e.
either (not sure of what sablecc allows)

  literal =
    [opening]:quote strand* [closing]:quote (language | datatype)?;

or

  literal =
    [opening]:quote strand* [closing]:quote datatype? |
    [opening]:quote strand* [closing]:quote language?;


  Cheers,

  Ronald