[Mulgara-dev] Fwd: [Mulgara-JIRA] Created: (MGR-26) Remove getElement() from the Constraint interface - An easy fix, no prior mulgara-internals experience required.

[Andrae Muys]

I'm not sure who's currently receiving jira updates, but anyone who  
is at all interested in becoming familiar with mulgara's internals  
might be interested in this one.  It's a pretty straight forward  
refactoring that should require little more than the ability to call  
grep and run the tests.

Andrae


Begin forwarded message:

> From: "Andrae Muys (JIRA)" <admin at mulgara.org>
> Date: 3 October 2006 4:30:17 PM
> To: andrae at netymon.com
> Subject: [Mulgara-JIRA] Created: (MGR-26) Remove getElement() from  
> the Constraint interface - An easy fix, no prior mulgara-internals  
> experience required.
>
> Remove getElement() from the Constraint interface - An easy fix, no  
> prior mulgara-internals experience required.
> ---------------------------------------------------------------------- 
> ------------------------------------------
>
>                  Key: MGR-26
>                  URL: http://mulgara.org/jira/browse/MGR-26
>              Project: Mulgara
>           Issue Type: Improvement
>             Reporter: Andrae Muys
>          Assigned To: Paul Gearon
>             Priority: Minor
>
>
> Back in the distant past when the only type of Constraint supported  
> was what we now refer to as ConstraintImpl, getElement() was an  
> ugly, but harmless way of obtaining the different elements of a  
> constraint.
>
> Now that we have dozens of different constraint types, the vast  
> majority of which have to implement getElement() by throwing an  
> exception, this is not so harmless.
>
> It would be great if someone could go through the codebase and:
>
> 1) Add getSubject(), getPredicate(), and getObject() to ConstraintImpl
> 2) Find each call to ConstraintImpl::getElement(), and replace with  
> the appropriate call (element 0->subject, 1->predicate, 2->object;  
> 3->model but that should already have been done).
> 3) Repeat for ConstraintNegation (and any other constraint type  
> that implements getElement(), but IIRC there aren't any).
> 4) Remove getElement() from the Constraint interface and  
> implementing classes thereby banishing this aberration.
>
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the  
> administrators: http://mulgara.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/ 
> software/jira
>
>

-- 
Andrae Muys
andrae at netymon.com
Principal Mulgara Consultant
Netymon Pty Ltd